#8 - set limit parameter to 5 and 15 to avoid large responses and red…

…uce the number of tests, added assert for number of features in the response
opengeospatial · Jul 2, 2018 · 17dbccd · 17dbccd
1 parent 3abce14
commit 17dbccd
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/main/java/org/opengis/cite/wfs30/collections/GetFeaturesOperation.java b/src/main/java/org/opengis/cite/wfs30/collections/GetFeaturesOperation.java
@@ -69,12 +69,11 @@ public Object[][] collectionItemUris( ITestContext testContext ) {
     @DataProvider(name = "collectionItemUrisWithLimit")
     public Object[][] collectionItemUrisWithLimits( ITestContext testContext ) {
         // TODO: find values between min and max described in OpenApi document (per collection)
-        Object[][] collectionsData = new Object[collections.size() * 3][];
+        Object[][] collectionsData = new Object[collections.size() * 2][];
         int i = 0;
         for ( Map<String, Object> collection : collections ) {
             collectionsData[i++] = new Object[] { collection, 5 };
-            collectionsData[i++] = new Object[] { collection, 100 };
-            collectionsData[i++] = new Object[] { collection, 1000 };
+            collectionsData[i++] = new Object[] { collection, 15 };
         }
         return collectionsData;
     }
@@ -394,11 +393,13 @@ public void validateLimitParameter_requests( Map<String, Object> collection, int
         Date timeStampAfterResponse = new Date();
 
         JsonPath jsonPath = response.jsonPath();
+        int numberOfFeatures = jsonPath.getList( "features" ).size();
+        assertTrue( numberOfFeatures <= limit, "Number of features for collection with name " + collectionName
+                                               + " is unexpected (was " + numberOfFeatures + "), expected are " + limit
+                                               + " or less" );
         assertTimeStamp( collectionName, jsonPath, timeStampBeforeResponse, timeStampAfterResponse );
         assertNumberReturned( collectionName, jsonPath );
         assertNumberMatched( collectionName, jsonPath );
-
-        // TODO: assert returned features
     }
 
     /**