-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiDatastream Extension tests #28
MultiDatastream Extension tests #28
Conversation
* Fixed base test to not fail on MultiDatastream. # Conflicts: # pom.xml # src/main/java/org/opengis/cite/sta10/SuiteFixtureListener.java # src/main/resources/org/opengis/cite/sta10/testng.xml
Fixes #39. |
… count for MultiDatastream observations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR uses a SensorThingsClient library. It means testing against SensorThings with a library that uses SensorThings but not tested against it.
In this case if there is any change to SensorThings that library needs to be updated as well as the ets-sta10 and that adds more delay. I would say if we want to use that library we'd better move the code here so that there is only one place we need to change.
Also the conflicts should be resolved.
If the library falls behind, you can always pull the library into the test suite at that point. Doing that when it's not needed is a (very) bad practice. |
What you are saying is correct in general for the libraries and that is why we use libraries in coding. |
I've added some tests for the MultiDatastream Extension.
Fixes #39.