Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiDatastream Extension tests #28

Closed

Conversation

hylkevds
Copy link
Contributor

@hylkevds hylkevds commented Nov 18, 2016

I've added some tests for the MultiDatastream Extension.

Fixes #39.

* Fixed base test to not fail on MultiDatastream.

# Conflicts:
#	pom.xml
#	src/main/java/org/opengis/cite/sta10/SuiteFixtureListener.java
#	src/main/resources/org/opengis/cite/sta10/testng.xml
@dstenger
Copy link
Contributor

Fixes #39.

Copy link
Contributor

@taniakhalafbeigi taniakhalafbeigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR uses a SensorThingsClient library. It means testing against SensorThings with a library that uses SensorThings but not tested against it.
In this case if there is any change to SensorThings that library needs to be updated as well as the ets-sta10 and that adds more delay. I would say if we want to use that library we'd better move the code here so that there is only one place we need to change.

Also the conflicts should be resolved.

@hylkevds
Copy link
Contributor Author

hylkevds commented Nov 28, 2018

If the library falls behind, you can always pull the library into the test suite at that point. Doing that when it's not needed is a (very) bad practice.
If you really want to maintain your own (copy of) a client library, you should do it in a separate project, so that its use is not limited to just the test suite. Otherwise you're just wasting your time with duplicate work.

@taniakhalafbeigi
Copy link
Contributor

What you are saying is correct in general for the libraries and that is why we use libraries in coding.
The problem here is different though. This is the test suite for SensorThings. The OGC test suite should be self-contained with anything related to the standard that it is testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test-suite fails on any server that implements MultiDatastreams.
3 participants