Rely on MaximizeUsingFullscreenGeometryHint flag to provide fullscreen experience on Android #5950
+41
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
commented
Jan 20, 2025
| if (dimension > 0) { | ||
| margin = dimension; | ||
| } | ||
| private Insets getSafeInsets() { |
There was a problem hiding this comment.
A note on this function: we'll be able to get rid of this one altogether when we move to Qt >= 6.9, where we finally have a safeAreaMargins implementation for Android (see https://bugreports.qt.io/browse/QTBUG-131519). We already use QPlatformWindow's safeAreaMargins on iOS and it'll be nice to use it for Android too.
That said, this is for a much latter date. Just stating for the record :)
|
🎉 Ta-daaa, freshly created APKs are available for f2f9dbf: arm64-android |
nirvn
force-pushed
the
android_fullscreen_upstream
branch
from
3224452 to
0984628
Compare
…n experience on Android
nirvn
force-pushed
the
android_fullscreen_upstream
branch
from
0984628 to
f2f9dbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of our custom fullscreen handling on Android in favor of relying on the QML Window's MaximizeUsingFullscreenGeometryHint flag (like we already do on iOS).
On top lifting the burden of maintaining custom code by moving to Qt project code itself, using the flag provides a context that other parts of Qt may rely on to pick behavior based on the presence/absence of the flag (e.g. handlers).