-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't handle xml files 2 times #845
Conversation
They are already handled by FileDropListView.ValidExtenstions Fix #837
Now I get it, what is happening here. Thanks for this PR. We only want to open our dialog on the extensions ["xtf", "XTF", "itf", "ITF", "ili"] and not on XML, xml - that's why this list So the problem is not that So the solution would be:
Can you do it or - if you are busy - I can do it, since I know now what it is about. |
ea8e763
to
ef6221f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good. Thanks.
I could only test drops in the main QGIS windows, as the wizard dialog disappears for me when clicking outside in the file manager (maybe a KDE thisg?). In the main window behaviour is following:
In the wizard (untested):
|
But when you drop xtf, itf, ili, xml, ini, toml in the main window all are accepted, right? (because at least one INTERLIS file) |
Maybe yes... |
Exactly, if at least one xtf, itf, ili is in the list, then all are accepted |
They are already handled by FileDropListView.ValidExtenstions
Fix #837