fix(ndi): fix missing kid on JWS header #608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After refactor of the NDI implementation to use
jose
library in #595,kid
is no longer being set on the ID token JWS header. This is breaking verification of the ID token JWS, as RPs need to select the appropriate key from the OP JWKS based on thekid
value for verification.Accessing
signingKey.kid
doesn't work assigningKey
is fromjose.importJWK()
, which is a genericcrypto
libraryKeyObject
that isn't aware of JWK and so doesn't have the concept of thekid
. In the implementation prior to refactor thesigningKey
appears to be some kind of JWK-aware thing so it had thekid
.Closes #604
Solution
Bug Fixes:
kid
header value from the original pre-parsing-into-KeyObject JSON object.