Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLU-335] TILES: incremental row fetching #808

Merged
merged 5 commits into from
Dec 16, 2024
Merged

[PLU-335] TILES: incremental row fetching #808

merged 5 commits into from
Dec 16, 2024

Conversation

pregnantboy
Copy link
Contributor

Problem

Large tiles take too long to show anything. And requests may timeout.

Solution

Incrementally paginate on the frontend.

image

@pregnantboy pregnantboy requested a review from a team as a code owner December 4, 2024 08:05
@linear Linear
Copy link

linear bot commented Dec 4, 2024

PLU-335 Tiles incremental row loading

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 4, 2024 •
edited
Loading

Datadog Report

Branch report: chore/tiles/incremental-row-fetching
Commit report: 553f774
Test service: plumber

✅ 0 Failed, 709 Passed, 0 Skipped, 2m 12.94s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.06%)

@pregnantboy pregnantboy mentioned this pull request Dec 4, 2024
Closed
m0nggh
m0nggh approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@m0nggh m0nggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok tested that the findSingleRow action works and fetching of large tile is done incrementally

@pregnantboy
Update schema.graphql
22323f9 
fix: remove unused arg
@pregnantboy pregnantboy merged commit 8ae0205 into develop-v2 Dec 16, 2024
3 of 4 checks passed
@pregnantboy pregnantboy deleted the chore/tiles/incremental-row-fetching branch December 16, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@m0nggh m0nggh m0nggh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pregnantboy @m0nggh