Invert color temperature percentage range #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Krug <[email protected]>
Signed-off-by: Michael Krug <[email protected]>
michikrug
force-pushed
the
invert-color-percent
branch
from
13a289f to
474d86e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned at https://community.openhab.org/t/oh3-color-light-bulb-and-google-assistant/129938/7, there is some confusion about the relationship between color temperatures and their percentage equivalent.
In the current implementation, the percent values are inverted before conversion to Kelvin. I honestly don't know why this was implemented this way.
To make this more intuitive, we remove the inversion and reflect low kelvin values to low percent values and vice versa.