OpenJDK: Adding Java 11 into our package #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synology dropped any Java package from their software repository. It is unknown whether they will ever add Java at all. As OpenHAB itself recommends specific version(s) of Java for installation, I'm adding this feature not only to get independent from Synology, but also to get back full control over our installation. This work has not been tested. Some corrections might follow. Signed-off-by: Thomas Karl Pietrowski <[email protected]> (github: thopiekar)
|
Hi @thopiekar thank you, for your commit, but sign-off your commit, please: |
cniweb
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @thopiekar)
|
Is included everywhere. Is DCO picky? I don't see a mistake. |
|
Adding this is a bad idea actually. I only download the x86_64 version and don't care about other architectures. |
thopiekar
deleted the
master-adding-openjdk-download-and-install-into-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synology dropped any Java package from their software repository in DSM. It is unknown whether they will ever add Java at all.
As OpenHAB itself recommends specific version(s) of Java for installation, I'm adding this feature not only to get independent of Synology, but also to get back full control over our installation.
This work has not been tested. Some corrections might follow.
Signed-off-by: Thomas Karl Pietrowski [email protected] (github: thopiekar)
This change is