Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support email registration #230

Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat: Support email registration #230

merged 2 commits into from
Nov 2, 2023

Conversation

luhaoling
Copy link
Contributor

@luhaoling luhaoling commented Oct 12, 2023


🔍 What type of PR is this?

This PR is added to support email registration.

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fix #221

📝 Special notes for your reviewer:

When you want to use other maibox to send email,you just to update the fileds "sendMail senderAuthorizationCode smtpAddr smtpPort" of the config/config.yaml.

🎯 Describe how to verify it

When you invoke the send verification api, fill in the email and leave the mobile number field blank.

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

None.

@luhaoling luhaoling requested review from cubxxw and a team as code owners October 12, 2023 03:16
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2023
@kubbot
Copy link
Contributor

kubbot commented Oct 12, 2023

CLA Assistant Lite bot 🤖 All Contributors have signed the chat CLA.
The signed information is recorded 🤖here

@luhaoling luhaoling temporarily deployed to openim October 20, 2023 03:25 — with GitHub Actions Inactive
@luhaoling luhaoling temporarily deployed to openim October 20, 2023 03:25 — with GitHub Actions Inactive
@luhaoling luhaoling temporarily deployed to openim October 20, 2023 03:25 — with GitHub Actions Inactive
@luhaoling
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@luhaoling
Copy link
Contributor Author

recheck

openimbot added a commit to openim-sigs/cla that referenced this pull request Oct 31, 2023
@luhaoling luhaoling temporarily deployed to openim October 31, 2023 02:18 — with GitHub Actions Inactive
@luhaoling luhaoling temporarily deployed to openim October 31, 2023 02:18 — with GitHub Actions Inactive
@luhaoling luhaoling temporarily deployed to openim October 31, 2023 02:18 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 31, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@@ -0,0 +1,59 @@
// Copyright © 2023 OpenIM open source community. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Util Test Function

@cubxxw cubxxw enabled auto-merge November 2, 2023 09:22
@cubxxw cubxxw added this pull request to the merge queue Nov 2, 2023
Merged via the queue into openimsdk:main with commit 31aff39 Nov 2, 2023
13 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants