Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 365 #367

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Fix bug 365 #367

merged 2 commits into from
Jan 4, 2024

Conversation

skiffer-git
Copy link
Member


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #365

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@skiffer-git skiffer-git requested review from cubxxw and a team as code owners January 4, 2024 07:22
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2024
Copy link

sweep-ai bot commented Jan 4, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@kubbot
Copy link
Contributor

kubbot commented Jan 4, 2024

CLA Assistant Lite bot 🤖 All Contributors have signed the chat CLA.
The signed information is recorded 🤖here

@skiffer-git
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@cubxxw cubxxw enabled auto-merge (squash) January 4, 2024 07:27
@skiffer-git skiffer-git disabled auto-merge January 4, 2024 07:32
@skiffer-git skiffer-git merged commit c9b5b98 into openimsdk:release-v1.5 Jan 4, 2024
16 of 17 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants