Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the component check logic to make it better #417

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

luhaoling
Copy link
Contributor

@luhaoling luhaoling commented Mar 4, 2024


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #418

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@luhaoling luhaoling requested review from cubxxw and a team as code owners March 4, 2024 10:22
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2024
@luhaoling luhaoling changed the title fix: fix the component logic fix: fix the component check logic to make it better Mar 4, 2024
@cubxxw cubxxw added this pull request to the merge queue Mar 4, 2024
Merged via the queue into openimsdk:main with commit 63b0491 Mar 4, 2024
11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: component logic is not good enough
3 participants