Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903774: make all tests combinations printing nicer and/or configurable #153

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

judovana
Copy link

@judovana judovana commented Nov 14, 2024

This is still WIP, but already on row what CODETOOLS-7903774 suggested.

It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable.

From:

`TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149
`COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact
`ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149
`COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910
`COMBINATIONS_JSON` same as combinations, but a valid json
`COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed 
  • TESTS are already implemented as ALL_MATCHING
  • COMBINATIONS as ALL_MATCHING_COMBINATIONS
  • ALL_TESTS as ALL

COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development.
The _JSON variants are tobe decided, but ability to JQL it sounds nice.

Suggestion to better names welcomed.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7903774: make all tests combinations printing nicer and/or configurable (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153
$ git checkout pull/153

Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.org/jcstress.git pull/153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 153

View PR using the GUI difftool:
$ git pr show -t 153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/153.diff

Using Webrev

Link to Webrev Comment

instead of misusing verbose switch
and thus returned the ability to print allavailable tetest
@judovana judovana changed the title CODETOOLS-7903774 CODETOOLS-7903774 make all tests combinations printing nicer and/or configurable Nov 14, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2024

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title CODETOOLS-7903774 make all tests combinations printing nicer and/or configurable 7903774: make all tests combinations printing nicer and/or configurable Nov 14, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2024

Webrevs

@judovana judovana marked this pull request as draft November 14, 2024 18:06
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 14, 2024
@judovana judovana marked this pull request as ready for review November 15, 2024 17:46
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2024
@judovana
Copy link
Author

Implemented
COMBINATIONS_GROUPED and COMBINATIONS_GROUPS (as MATCHING_GROUPS and MATCHING_GROUPS_COUNT) also with its inverted variants

The nice json will maybe need some refactorings. WIP on it, but any feedback appreciated

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2024

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant