Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344778: javac is not generating the ConstantValue attribute for non-final static fields #22367

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Nov 25, 2024

still a work in progress


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8344780 to be approved

Warning

 ⚠️ Found leading lowercase letter in issue title for 8344778: javac is not generating the ConstantValue attribute for non-final static fields

Issues

  • JDK-8344778: javac is not generating the ConstantValue attribute for non-final static fields (Bug - P4)
  • JDK-8344780: javac is not generating the ConstantValue attribute for non-final static fields (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22367/head:pull/22367
$ git checkout pull/22367

Update a local copy of the PR:
$ git checkout pull/22367
$ git pull https://git.openjdk.org/jdk.git pull/22367/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22367

View PR using the GUI difftool:
$ git pr show -t 22367

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22367.diff

@vicente-romero-oracle vicente-romero-oracle marked this pull request as draft November 25, 2024 17:34
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2024

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 25, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Nov 25, 2024
@openjdk
Copy link

openjdk bot commented Nov 25, 2024

@vicente-romero-oracle The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler [email protected] csr Pull request needs approved CSR before integration
Development

Successfully merging this pull request may close these issues.

1 participant