8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter

[RealFYang]

Hi, please consider this small interpreter cleanup change.

The use of AvoidUnalignedAccesses option for these cases doen't much sense to me.
MacroAssembler routines like revb_h_h_u and revb_h_h will emit 5 instructions when Zbb extension is not available. This is more than the case when AvoidUnalignedAccesses option is true. After this change, we always emit 4 instructions compared to 3 instructions in the case when we have Zbb extension. But I don't think it will make a difference.

Testing on linux-riscv64 platform:

• tier1 (release)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter (Enhancement - P4)

Reviewers

• Hamlin Li (@Hamlin-Li - Reviewer)
• Feilong Jiang (@feilongjiang - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22387/head:pull/22387
$ git checkout pull/22387

Update a local copy of the PR:
$ git checkout pull/22387
$ git pull https://git.openjdk.org/jdk.git pull/22387/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22387

View PR using the GUI difftool:
$ git pr show -t 22387

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22387.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter

Reviewed-by: mli, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 08c1f44: 8341028: Do not use lambdas or method refs for verifyConstantPool
• 28c8729: 8343004: Adjust JAXP limits
• 8c2b4f6: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration
• 8389e24: 8345058: Javac issues different error messages for the modifiers of the requires directive
• 8da6435: 8343693: [JVMCI] Override ModifiersProvider.isConcrete in ResolvedJavaType to be isArray() || !isAbstract()
• 7ae6069: 8344184: Remove sun.net.ResourceManager after JEP 486 integration
• 1d5587b: 8344256: Clean up obsolete code in java.desktop/share/classes/sun/awt/datatransfer/DataTransferer.java
• 5e15415: 8344654: Some client tests still expect a SecurityManager after JEP486
• 3689f39: 8344013: "bad tag in log" assert with +LogCompilation +CITimeVerbose
• 9458a43: 8318416: Superscript marks should use consistent font style
• ... and 14 more: https://git.openjdk.org/jdk/compare/3a625f38aa4ab611fe5c7dffe420abce826d0d7e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@RealFYang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[RealFYang]

/label remove hotspot-compiler

[openjdk]

@RealFYang
The hotspot-compiler label was successfully removed.

[RealFYang]

/label add hotspot

[openjdk]

@RealFYang
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 00: Full (f75a0496)

[Hamlin-Li]

Thanks for improving the code.
Just some minor comments.

[Hamlin-Li]

Looks good. Thanks!
Since the changes are in the interpreter, I can accept minor regressions introduced in exchange for code readability.

[feilongjiang]

Looks good.

[RealFYang]

@Hamlin-Li @feilongjiang : Thanks.
/integrate

[openjdk]

Going to push as commit 82137db.
Since your change was applied there have been 29 commits pushed to the master branch:

• b3986bd: 8344118: C2 SuperWord: add VectorThroughputForIterationCount benchmark
• 96388be: 8345004: [BACKOUT] GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox.
• 4ae6ce6: 8344300: Implement JEP 499: Structured Concurrency (Fourth Preview)
• 57ee3ba: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign
• 1f6144e: 8345050: Fix -Wzero-as-null-pointer warning in MemPointer ctor
• 08c1f44: 8341028: Do not use lambdas or method refs for verifyConstantPool
• 28c8729: 8343004: Adjust JAXP limits
• 8c2b4f6: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration
• 8389e24: 8345058: Javac issues different error messages for the modifiers of the requires directive
• 8da6435: 8343693: [JVMCI] Override ModifiersProvider.isConcrete in ResolvedJavaType to be isArray() || !isAbstract()
• ... and 19 more: https://git.openjdk.org/jdk/compare/3a625f38aa4ab611fe5c7dffe420abce826d0d7e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang Pushed as commit 82137db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.