Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328379: Convert URLDragTest.html applet test to main #3002

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

toshiogata
Copy link
Contributor

@toshiogata toshiogata commented Feb 26, 2025

Hi all,

I would like to backport this patch to improve test maintainability. The patch is not clean. A text block needs to be replaced with string literals.
Testing: manually checked URLDragTest.java, and confirmed that the test works in the same way.

Thank you.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328379 needs maintainer approval

Issue

  • JDK-8328379: Convert URLDragTest.html applet test to main (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3002/head:pull/3002
$ git checkout pull/3002

Update a local copy of the PR:
$ git checkout pull/3002
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3002

View PR using the GUI difftool:
$ git pr show -t 3002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3002.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2025

👋 Welcome back toshiogata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 26, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fbeac98c84078a566c572abeba07c49e94bbf26b 8328379: Convert URLDragTest.html applet test to main Feb 26, 2025
@openjdk
Copy link

openjdk bot commented Feb 26, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 26, 2025
@toshiogata
Copy link
Contributor Author

toshiogata commented Feb 26, 2025

GHA report 1 test failure on macos-x64

  • serviceability/sa/ClhsdbFindPC.java#id1

This test failure occurs frequently in recent GHA runs, and is not related to this fix.
Perhaps related issue for this failure is https://bugs.openjdk.org/browse/JDK-8253028

@mlbridge
Copy link

mlbridge bot commented Feb 26, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant