Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344925: translet-name ignored when package-name is also set #1412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galderz
Copy link

@galderz galderz commented Feb 19, 2025

This is a backport of JDK-8344925: translet-name ignored when package-name is also set

Original patch does not apply cleanly to 21u-dev, because of javadoc and license header year discrepancies.

Testing: tier1 and tier2 passed. Tier 2 includes the PropertiesTest test included in the original PR and individually verified that it passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344925 needs maintainer approval

Issue

  • JDK-8344925: translet-name ignored when package-name is also set (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1412/head:pull/1412
$ git checkout pull/1412

Update a local copy of the PR:
$ git checkout pull/1412
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1412/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1412

View PR using the GUI difftool:
$ git pr show -t 1412

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1412.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2025

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3989a199578fc1d91988cfdbb95f11dd6d4c7b81 8344925: translet-name ignored when package-name is also set Feb 19, 2025
@openjdk
Copy link

openjdk bot commented Feb 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 19, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 19, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants