Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ReclaimPolicy for GameServer #115

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

chrisliu1995
Copy link
Member

@chrisliu1995 chrisliu1995 commented Dec 13, 2023

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (250bd86) 32.63% compared to head (c2aae1a) 35.47%.
Report is 4 commits behind head on master.

Files Patch % Lines
...kg/controllers/gameserver/gameserver_controller.go 0.00% 25 Missing ⚠️
...controllers/gameserverset/gameserverset_manager.go 63.93% 17 Missing and 5 partials ⚠️
pkg/util/gameserver.go 94.11% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   32.63%   35.47%   +2.83%     
==========================================
  Files          23       26       +3     
  Lines        3144     3538     +394     
==========================================
+ Hits         1026     1255     +229     
- Misses       2065     2217     +152     
- Partials       53       66      +13     
Flag Coverage Δ
unittests 35.47% <63.50%> (+2.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisliu1995 chrisliu1995 force-pushed the feat/gs_lifecycle branch 2 times, most recently from bb178b3 to 60ee3a4 Compare December 26, 2023 07:46
Copy link
Member

@ringtail ringtail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ringtail
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ringtail ringtail merged commit 5a15888 into openkruise:master Dec 28, 2023
7 of 8 checks passed
@chrisliu1995 chrisliu1995 changed the title feat: user-defined GameServers' lifecycle feat: add ReclaimPolicy for GameServer Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants