Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: patch pod image fail when gs image is nil #121

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

chrisliu1995
Copy link
Member

No description provided.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a15888) 35.47% compared to head (32a88e2) 35.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   35.47%   35.55%   +0.08%     
==========================================
  Files          26       26              
  Lines        3538     3535       -3     
==========================================
+ Hits         1255     1257       +2     
+ Misses       2217     2213       -4     
+ Partials       66       65       -1     
Flag Coverage Δ
unittests 35.55% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit b399cd1 into openkruise:master Dec 28, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants