Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add annotations config in clb plugin #137

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

lizhipeng629
Copy link
Contributor

When using the volcanoengine clb plugin, the configuration of clb is set through anno, opening this setting is convenient for users;

@kruise-bot kruise-bot requested review from FillZpp and furykerry April 11, 2024 11:33
@lizhipeng629 lizhipeng629 changed the title fix(*): add annotations config in clb plugin Enhance: Add annotations config in clb plugin Apr 11, 2024
@lizhipeng629 lizhipeng629 changed the title Enhance: Add annotations config in clb plugin enhance: Add annotations config in clb plugin Apr 11, 2024
@lizhipeng629 lizhipeng629 force-pushed the feat-clb-plugin-anno branch from 7c75387 to 84fb69e Compare April 11, 2024 11:47
@lizhipeng629 lizhipeng629 force-pushed the feat-clb-plugin-anno branch from 84fb69e to 53f64d6 Compare April 11, 2024 12:09
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flyer103
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flyer103
Copy link

/lgtm

@kruise-bot
Copy link

@flyer103: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flyer103
Copy link

flyer103 commented Apr 12, 2024

@ringtail PTAL

@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit 53b6920 into openkruise:master Apr 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants