Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update surface_composite.py #3189

Conversation

azimgivron
Copy link
Contributor

@azimgivron azimgivron commented Nov 8, 2024

Description

It is a bug fix. I changed the line for the rotation of composite surfaces to enable inplace rotation. I copy pasted the line from translate for which inplace works fine.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@shimwell
Copy link
Member

shimwell commented Nov 8, 2024

Nice, is it worth adding a test for this to prevent the bug returning

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano paulromano merged commit 70807b1 into openmc-dev:develop Nov 9, 2024
16 checks passed
@azimgivron
Copy link
Contributor Author

azimgivron commented Nov 15, 2024

Nice, is it worth adding a test for this to prevent the bug returning

@shimwell should I create a separate PR with the test? I haven’t had a chance to write it yet, but I can work on it next week.

magnoxemo pushed a commit to magnoxemo/openmc that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants