Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External sources alias sampler #3201

Merged
merged 25 commits into from
Nov 23, 2024
Merged

External sources alias sampler #3201

merged 25 commits into from
Nov 23, 2024
+30 −16

Commits on Nov 7, 2024

  1. trying to understand what it does!

    @magnoxemo
    magnoxemo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    54ec402 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Reset values of lattice offset tables when allocated (openmc-dev#3188)

    @pshriwise @magnoxemo
    pshriwise authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    693302b View commit details
    Browse the repository at this point in the history

  2. allowing varible offsets for polygon.offset (openmc-dev#3120) 

    Co-authored-by: Paul Romano <[email protected]>
    @shimwell @paulromano @magnoxemo
    2 people authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    26f08cb View commit details
    Browse the repository at this point in the history

  3. Update surface_composite.py (openmc-dev#3189)

    @azimgivron @magnoxemo
    azimgivron authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    5fe3191 View commit details
    Browse the repository at this point in the history

  4. add export_model_xml arguments to Model.plot_geometry and Model.calcu… 

    …late_volumes (openmc-dev#3190)

Co-authored-by: Nicolas Linden <[email protected]>
Co-authored-by: Paul Romano <[email protected]>
    @nplinden @paulromano @magnoxemo
    3 people authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c87f749 View commit details
    Browse the repository at this point in the history

  5. Fixes in MicroXS.from_multigroup_flux (openmc-dev#3192)

    @paulromano @magnoxemo
    paulromano authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    454df35 View commit details
    Browse the repository at this point in the history

  6. Fix documentation typo in boundary_type (openmc-dev#3196)

    @pshriwise @magnoxemo
    pshriwise authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3ad81c5 View commit details
    Browse the repository at this point in the history

  7. Add a vessel composite surface with ellipsoids on top and bottom. (op… 

    …enmc-dev#3168)

Co-authored-by: Patrick Shriwise <[email protected]>
Co-authored-by: Paul Romano <[email protected]>
    @nsedayilmaz @pshriwise
    @paulromano @magnoxemo
    3 people authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    70347ff View commit details
    Browse the repository at this point in the history

  8. Add PointCloud spatial distribution (openmc-dev#3161) 

    Co-authored-by: Patrick Shriwise <[email protected]>
Co-authored-by: Paul Romano <[email protected]>
    @gonuke @pshriwise
    @paulromano @magnoxemo
    3 people authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    030b3d8 View commit details
    Browse the repository at this point in the history

  9. Fix docstring for Model.plot (openmc-dev#3198)

    @paulromano @magnoxemo
    paulromano authored and magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6fd184a View commit details
    Browse the repository at this point in the history

  10. init_alias is private. I have to figure how to acces that in the sett… 

    …ings.cpp
    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3cd9ca9 View commit details
    Browse the repository at this point in the history

  11. ig it works?

    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ba55c03 View commit details
    Browse the repository at this point in the history

  12. not sure

    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2647dc9 View commit details
    Browse the repository at this point in the history

  13. implementing the suggested changes

    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    648510c View commit details
    Browse the repository at this point in the history

  14. don't need the int i again cause already decleared the data type

    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7a1b4ad View commit details
    Browse the repository at this point in the history

  15. fixing the typos

    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    93afa21 View commit details
    Browse the repository at this point in the history

  16. removing unnecessary spaces

    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7dccde7 View commit details
    Browse the repository at this point in the history

  17. defining the external_sources_alias_sample in souce.cpp cause it's fa… 

    …iling the tests
    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1643150 View commit details
    Browse the repository at this point in the history

  18. needed to use the extern in source.h and redefine in the source.cpp i… 

    …n openmc model namespace. ig it passes all the tests now
    @magnoxemo
    magnoxemo committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f0656bd View commit details
    Browse the repository at this point in the history

  19. Merge branch 'develop' into external_sources_alias_sampler

    @magnoxemo
    magnoxemo authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    763dd74 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Fix uniform source sampling

    @paulromano
    paulromano committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b8e0ca6 View commit details
    Browse the repository at this point in the history

  2. Add test for multiple sources

    @paulromano
    paulromano committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    8ef3379 View commit details
    Browse the repository at this point in the history

  3. Change name to external_sources_probability

    @paulromano
    paulromano committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    47db5a7 View commit details
    Browse the repository at this point in the history

  4. Two comments

    @paulromano
    paulromano committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    8dba43e View commit details
    Browse the repository at this point in the history

  5. Update result for source regression test

    @paulromano
    paulromano committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    2fdf150 View commit details
    Browse the repository at this point in the history