Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support set client.id with Zone ID for Kafka driver #424

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Support set client.id with Zone ID for Kafka driver #424

merged 2 commits into from
Dec 2, 2024

Conversation

codelipenghui
Copy link
Contributor

Motivation

The steps to assign the Zone ID to the Kafka client ID

  1. Set JVM options when starting the benchmark worker, e.g. JVM_OPTS=-Dzone.id=usw1-az1
  2. Set the client.id to the commonConfig section in the Kafka driver file, e.g. client.id=xxx-{zone.id}

@merlimat merlimat merged commit b10b227 into openmessaging:master Dec 2, 2024
1 check passed
@codelipenghui codelipenghui deleted the penghui/kafka-client-id branch December 2, 2024 23:18
yaalsn pushed a commit to streamnative/benchmark that referenced this pull request Dec 3, 2024
@codelipenghui @yaalsn
Support set client.id with Zone ID for Kafka driver (openmessaging#424)
d5b78da 
* Support set client.id with Zone ID for Kafka driver

* Apply spotless fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codelipenghui @merlimat