Implement entitlement overrides OM738 #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turip
approved these changes
Aug 15, 2024
| ctx = entutils.NewTxContext(ctx, tx) | ||
|
|
||
| // Delete previous entitlement | ||
| // FIXME: we publish an event during this even if we fail later |
There was a problem hiding this comment.
This should be fine for now, but I agree that we should revamp trns handling, and provide hooks for publishing only if the whole transaction seems ok to commit (it's not 100% but better than the current situation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Users need a 0 downtime option to change a subject's entitlements. This is especially important for plan upgrade/downgrade scenarios.
Fixes #OM738
Notes for Reviewers