feat: simplify dlq setup #1369
Merged
feat: simplify dlq setup #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turip
force-pushed
the
refactor/add-proper-dlq
branch
from
b2ca62e to
a73b2fb
Compare
sagikazarmark
previously approved these changes
Aug 15, 2024
turip
force-pushed
the
refactor/add-proper-dlq
branch
from
e0af874 to
3bb8ee3
Compare
Given that most of our consumers are implicity depending on the ordering of the messages, this patch drops the retry queues and adds a simple DLQ solution.
turip
force-pushed
the
refactor/add-proper-dlq
branch
from
3bb8ee3 to
8831608
Compare
tothandras
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Given that most of our consumers implicitly depend on the ordering of the messages, this patch drops the retry queues and adds a simple DLQ solution.
The balance worker ignores any messages (e.g. ingest) coming after an entitlement deletion, but we are relying on the ordering there.
The notification worker relies on per-subject ordering so that it can check the database for previously sent alerts. Right now, out-of-order snapshots might trigger false notifications. (We can work around that.)
OSS-54