feat: invoice lifecycle #1766
Merged
feat: invoice lifecycle #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turip
force-pushed
the
feat/invoice-lifecycle
branch
5 times, most recently
from
b46f243 to
39fc1aa
Compare
turip
added
release-note/feature
turip
force-pushed
the
feat/invoice-lifecycle
branch
from
39fc1aa to
a3c6310
Compare
hekike
reviewed
Oct 30, 2024
| @@ -316,7 +327,119 @@ func (r *adapter) AssociatedLineCounts(ctx context.Context, input billing.Associ | |||
| }, nil | |||
| } | |||
|
|
|||
| func mapInvoiceFromDB(invoice db.BillingInvoice, expand billing.InvoiceExpand) (billingentity.Invoice, error) { | |||
| func (r *adapter) validateUpdateRequest(req billing.UpdateInvoiceAdapterInput, existing *db.BillingInvoice) error { | |||
| if !existing.UpdatedAt.Equal(req.UpdatedAt) { | |||
There was a problem hiding this comment.
shouldn't this be Before/After?
There was a problem hiding this comment.
Nope this ensures that the update object that was posted is based on the exact version in the database.
| // CalculateDraftUntilIfMissing calculates the draft until date if it is missing. | ||
| // If it's set we are not updating it as the user should update that instead of manipulating the | ||
| // workflow config. | ||
| func CalculateDraftUntilIfMissing(i *Invoice) (bool, error) { |
There was a problem hiding this comment.
nit: IsAutoDraftAllowed? Or maybe I'm not understanding fully context but naming feels hard to interepret
There was a problem hiding this comment.
What this function does is that it Calculates the Draft Until field If it is Missing from the invoice.
openmeter/billing/service/invoice.go
Outdated
| @@ -262,3 +279,91 @@ func (s *Service) gatherInscopeLines(ctx context.Context, input billing.CreateIn | |||
|
|
|||
| return lines, nil | |||
| } | |||
|
|
|||
| func (s *Service) getInvoiceFSMWithLock(ctx context.Context, txAdapter billing.Adapter, invoiceID billingentity.InvoiceID) (*InvoiceStateMachine, error) { | |||
There was a problem hiding this comment.
nit: what is FSM? Should we write it out?
hekike
previously approved these changes
Oct 30, 2024
hekike
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement a basic lifecycle for the invoices with the required hook points for external systems. We are using stateless for state management.
We are using unified trigger names and expose the available next steps as part of the API.
Endpoint fixes
Rename the /workflow/approve to /approve (as it's better aligned with the other endpoints)
Add /retry to retry failed actions after fixing the issues
Invoice changes
The field status field will only contain the main status (draft, issuing, etc)
A statusDetails field will contain the immutability flags, failure flags, extended status value, plus the list of available actions.