feat: billing add subscription metadata to lines #1959
Conversation
| @@ -0,0 +1,7 @@ | |||
| -- modify "billing_invoice_lines" table | |||
| ALTER TABLE "billing_invoice_lines" ADD COLUMN "subscription_id" character(26) NULL, ADD COLUMN "subscription_item_id" character(26) NULL, ADD COLUMN "subscription_phase_id" character(26) NULL, ADD | |||
| CONSTRAINT "billing_invoice_lines_subscription_items_billing_lines" FOREIGN KEY ("subscription_item_id") REFERENCES "subscription_items" ("id") ON UPDATE NO ACTION ON DELETE SET NULL, ADD | |||
There was a problem hiding this comment.
@hekike I have intentionally (not) set the cascade deletion as we should not delete items even if a subscription gets deleted. (We cannot falsify the past)
turip
added
area/api
release-note/feature
| * Subscription are the references to the subscritpions that this line is related to. | ||
| */ | ||
| @visibility("read") | ||
| subscriptions?: InvoiceLineSubscriptionReference; |
There was a problem hiding this comment.
Should this be singular? Looks like reference is for one.
| // NOTE: this can be used to have a type, that we can later replace with the expanded type if needed without | ||
| // breaking api compatibility | ||
| @friendlyName("IDResource") | ||
| model IDResource { |
There was a problem hiding this comment.
What's the value of doing IDResource? Is the resource type changing for the fields where it's used?
There was a problem hiding this comment.
This btw reminds me of GraphQL's global IDs where every resource's ID is globally unique. Usually it's a concatenation of the type and ID .
There was a problem hiding this comment.
This is just an API compatibility issue. This allows the response to be like this:
{
"subscription": {
"subscription": {
"id": ...
},
"phase": {
"id": ...
}
...
}
This way if we want to extend the API with extending the objects later, we can do that without needing to break the API.
Overview
Add subscription metadata for lines.
We only support setting it via internal APIs, externally the user cannot update/create lines with subscription references.