TRUNK-6041: Proper Restriction of XML External Entity Reference to prevent XXE attacks #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherman22
force-pushed
the
TRUNK-6041
branch
3 times, most recently
from
d419aa4 to
a263fc5
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ghost
reviewed
Mar 29, 2024
mherman22
changed the title
|
@mherman22 did you include the ticket id in the commit message? |
…event XXE attacks
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
The following SAXReader features have been configured in order to properly restrict xml external entity references in order to prevent xxe attacks and other security concerns:
http://apache.org/xml/features/disallow-doctype-decl: This disables the processing of Document Type Definitions (DTDs) which can be exploited for XXE attacks.http://xml.org/sax/features/external-general-entities: This disables the loading of external general entities, another way to launch XXE attacks.http://xml.org/sax/features/external-parameter-entities: This disables the processing of external parameter entities which is another way to perform XXE attacks.Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6041
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master