(fix) O3-4081: Help button has no icon when hovering over it #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denniskigen can you checkout this PR ? |
brandones
requested changes
Nov 18, 2024
| @@ -43,6 +43,7 @@ export default function HelpMenu() { | |||
| className={classNames(styles.helpMenuButton)} | |||
| > | |||
| <Help size={24} /> | |||
| {!helpMenuOpen && <span className={styles.helpLabel}>Help</span>} {/* Label is hidden when menu is open */} | |||
There was a problem hiding this comment.
Hi @virajwathsalag , sorry this took so long to get a review. I don't know why whoever wrote this initially chose to implement it as a <button> wrapping an icon component; this seems like a natural fit for the IconButton component, which handles the label tooltip. Could you please rework this code to use the IconButton?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
The help button doesn't have any label when hovered above it like other components
So, I added a label to it when hovered above the help icon the "help" label is displayed and also when clicked on the help button the help label hides.
Screenshots
2024-10-20.08-10-19.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-4081
Other