-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(O3-2491): Improved Time Rendering Logic Implementation #171
Conversation
Hey @denniskigen, changes are made based on request, time component is rendered on it's own, irrespective of the date component. |
@senthil-k8s did you see the build failure? Do you still have the bandwidth to push this? |
I haven't seen this; I'll look into it. Thanks @samuelmale for noticing |
@senthil-k8s please note that we need to proactively gear this work up because most of the form-engine tasks under this epic are candidates of the upcoming hackathon and the goal is to have these low hanging fruits out of the way prior to the hackathon. Same case applies other tasks like this. If you think you don't have enough suspense or not sure on how to address the issues, kindly feel free to pickup some other work to create room for the dedicated workforce. Thanks for your amazing contributions! |
@samuelmale, build error resolved, as well as in other cases. Logic is written in the same date component, which ensures that time and date components rendered separately. As well, the logic works for both rendering the datetime simultaneously. else time needs to be in a separate component? |
From the attached GIF, this seems to capture |
Closing this because of the lack of a real world usecase |
Requirements
Summary
Currently the form engine supports
date
anddatetime
rendering only.Within the
inbuiltControls.ts
all the controls are listed and addedtime
seperatelyBoth
date
anddatetime
rendering useOHRIDate
(Component Link). So, I decided to add thetime
logic inside of the component.Screenshots
https://www.loom.com/share/ac4128e2ea9745798baea042de665866?sid=ba1308d5-2b6f-40d5-bec1-6c3d6866bc6e
Related Issue
https://openmrs.atlassian.net/browse/O3-2491
Other
While Fetching, we have to ensure that time is also separate. questionTypes.