Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Attempt to fix "husky install" error encountered when installing this package in other npm packages #182

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

samuelmale
Copy link
Member

@samuelmale samuelmale commented Apr 11, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

In this commit, I re-configured husky to be setup post-install. However, this seems to cause issues to node package managers while installing the form engine package:

yarn up @openmrs/openmrs-form-engine-lib@next

The above fails with an error:

# This file contains the result of Yarn building a package (@openmrs/openmrs-form-engine-lib@virtual:e75de3f186b54590837537a83d468150282129aeef43e13da8549bc1aa24e405e34914d245fc3a18728e2a1206ca76ade50d4fbbe0dd598a244e06c02b75ced8#npm:1.0.0-pre.587)
# Script name: postinstall

command not found: husky

Screenshots

Related Issue

Other

@samuelmale samuelmale requested a review from pirupius April 11, 2024 10:23
Copy link

Size Change: 0 B

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size
dist/184.js 203 kB
dist/207.js 6.07 kB
dist/225.js 9.82 kB
dist/272.js 6.59 kB
dist/294.js 2.63 kB
dist/366.js 6.94 kB
dist/417.js 237 kB
dist/693.js 1.58 kB
dist/709.js 2.42 kB
dist/787.js 822 B
dist/800.js 169 kB
dist/9.js 90.2 kB
dist/main.js 315 kB
dist/openmrs-form-engine-lib.js 3.4 kB

compressed-size-action

@samuelmale samuelmale merged commit 7ddb9f1 into main Apr 11, 2024
5 checks passed
@samuelmale samuelmale deleted the chore/fix-husky branch April 11, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants