-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Bump esm-form-entry-app
to Angular v14
#1414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ibacher
previously approved these changes
Oct 14, 2023
Any tips for how to fix the failing conditions spec here, @jayasanka-sack? |
vasharma05
force-pushed
the
chore/upgrade-form-entry-to-angular-v14
branch
from
October 16, 2023 12:49
f4b82cc
to
96d74dc
Compare
vasharma05
previously approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
vasharma05
previously approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!!!
vasharma05
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Necessitated by openmrs/openmrs-ngx-formentry#88.
This PR updates Angular to v14. Additionally, I've:
@angular-architects/module-federation
with a version of ngx-build-plus that is compatible with Angular v14. I've also updated our custom webpack config, replacing the deprecatedcontentBase
property of thedevServer
config and adding ascriptType
property with the valuetext/javascript
(which fixes this issue with the webpack build output not matching the structure of an O3 federated module).ngx-file-uploader-openmrs
dependency with @openmrs/ngx-file-uploader after I recently migrated the source repository to the OpenMRS GitHub organization.main
).Relates to openmrs/openmrs-ngx-formentry#89.
Screenshots