(fix) O3-4123: Improve queue entry removal UX and modal styling #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
reviewed
Jan 18, 2025
...-service-queues-app/src/queue-table/queue-entry-actions/queue-entry-confirm-action.modal.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-table/queue-entry-actions/end-queue-entry.modal.tsx
Outdated
Show resolved
Hide resolved
...-service-queues-app/src/queue-table/queue-entry-actions/queue-entry-confirm-action.modal.tsx
Outdated
Show resolved
Hide resolved
harshthakkr
force-pushed
the
fix/remove-patient-modal-width-and-action-button
branch
from
806fa78 to
ace4226
Compare
chibongho
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Thanks @harshthakkr , this looks great.
Once obvious todo would be to similarly improve the wording for the Delete and Undo Transition modals. That doesn't seem to be in scope for this ticket, so I filed a separate ticket for this. (We might need some discussions on the wordings before it's ready to be worked on.)
harshthakkr
force-pushed
the
fix/remove-patient-modal-width-and-action-button
branch
from
ace4226 to
c54e6f8
Compare
|
@denniskigen, could you please review it? Thanks! |
samuelmale
approved these changes
Jan 28, 2025
packages/esm-service-queues-app/src/queue-table/queue-entry-actions/end-queue-entry.modal.tsx
Outdated
Show resolved
Hide resolved
denniskigen
reviewed
Jan 28, 2025
packages/esm-service-queues-app/src/queue-table/queue-entry-actions/end-queue-entry.modal.tsx
Outdated
Show resolved
Hide resolved
...-service-queues-app/src/queue-table/queue-entry-actions/queue-entry-confirm-action.modal.tsx
Outdated
Show resolved
Hide resolved
denniskigen
changed the title
denniskigen
reviewed
Jan 28, 2025
...m-service-queues-app/src/clear-queue-entries-dialog/clear-queue-entries-dialog.component.tsx
Show resolved
Hide resolved
Co-authored-by: OpenMRS Bot <[email protected]>
harshthakkr
force-pushed
the
fix/remove-patient-modal-width-and-action-button
branch
from
7869e66 to
3f37ec9
Compare
|
Thanks! |
harshthakkr
deleted the
fix/remove-patient-modal-width-and-action-button
branch
Samstar10
pushed a commit
to Samstar10/openmrs-esm-patient-management
that referenced
this pull request
Feb 4, 2025
…mrs#1451) * fix: modify the text and use destructive action button * fix: Update modal instruction * fix: Remove patient modal width * fix: width of Delete and Undo transition modals * test: Update test for queue-entry-confirm-action * fix: Change name from isRemovePatient to isRemovingPatientFromQueue * (chore) Update translations from Transifex (openmrs#1473) Co-authored-by: OpenMRS Bot <[email protected]> * fix: Requested changes * Revert "fix: Requested changes" This reverts commit 3f37ec9. * fix: Requested changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: OpenMRS Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR improves consistency in the UI by making the following adjustments:
Screenshots
Remove modal
Before
After
Delete modal
Before
After
Undo Transition modal
Before
After
Related Issue
O3-4123
Note
The updates to the Transition string are applied only to the English language (i.e., en.json), as I am not familiar with other languages.