Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix some unit tests not verifying properly due to missing await when calling waitFor() #895

Closed
wants to merge 3 commits into from

Conversation

chibongho
Copy link
Contributor

Requirements

Summary

https://openmrs.atlassian.net/browse/O3-2632

Some unit tests in openmrs-esm-patient-management are missing await when calling waitFor(). As a result, the expect() calls inside the waitFor() lambda are not throwing exceptions properly, and any expect() calls that fail do not actually fail the test case.

Screenshots

None.

Related Issue

None.

Other

Most tests can be fixed with just adding a simple await, but there is a test that failed in address-search-component.test.tsx after doing that that I don’t know how to fix. Marking it as skipped for now, and will assign @vasharma05 to fix.

@denniskigen
Copy link
Member

Hey @chibongho, I don't know if the changes in #900 obviate the issue? If not, please fix the conflicts so we can proceed with this work.

@chibongho
Copy link
Contributor Author

Hey @chibongho, I don't know if the changes in #900 obviate the issue? If not, please fix the conflicts so we can proceed with this work.

I believe so. I'll close this ticket then. Thanks @denniskigen

@chibongho chibongho closed this Dec 13, 2023
@denniskigen
Copy link
Member

Thanks, @chibongho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants