(fix) KH-180: Fixed the min and max validator for number inputs to va…

…lidate value 0 (#52) * Fixed the min and max validator for number inputs to validate value 0 * Removed the console.logs
openmrs · Jun 7, 2023 · 381c153 · 381c153
1 parent 3abb968
commit 381c153
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/projects/ngx-formentry/src/form-entry/validators/max.validator.ts b/projects/ngx-formentry/src/form-entry/validators/max.validator.ts
@@ -7,7 +7,11 @@ export class MaxValidator {
         return null;
       }
 
-      if (control.value && control.value.length !== 0) {
+      // Case 1: control.value is a number
+      // all the numbers should be passed for validation
+      // Case 2: control.value is not a number:
+      // if its empty string or null or undefined it will return false else it will pass through for validation
+      if (typeof control.value === 'number' || control.value) {
         const v: number = control.value;
         return v <= max
           ? null

diff --git a/projects/ngx-formentry/src/form-entry/validators/min.validator.ts b/projects/ngx-formentry/src/form-entry/validators/min.validator.ts
@@ -6,7 +6,12 @@ export class MinValidator {
       if (control.hidden) {
         return null;
       }
-      if (control.value && control.value.length !== 0) {
+
+      // Case 1: control.value is a number
+      // all the numbers should be passed for validation
+      // Case 2: control.value is not a number:
+      // if its empty string or null or undefined it will return false else it will pass through for validation
+      if (typeof control.value === 'number' || control.value) {
         const v: number = control.value;
         return v >= min
           ? null