Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Resolved issue with incorrect voided diagnosis in generated payload #107

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

icrc-psousa
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Resolved an issue during encounter editing where the generated payload incorrectly marked existing diagnoses as voided, despite intending to retain them. With this fix, only the diagnoses explicitly removed by the user will be marked as voided in the payload as expected.

This issue had minimal impact as an HTTP 400 error would occur due to an unrelated problem in the OpenMRS core, preventing the editing of existing diagnoses.

@icrc-psousa icrc-psousa requested a review from ibacher December 13, 2023 15:58
@ibacher ibacher merged commit 16867a5 into main Dec 13, 2023
3 checks passed
@ibacher ibacher deleted the fix/delete-diagnosis branch December 13, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants