Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Enable readonly radio buttons #109

Merged
merged 2 commits into from
Feb 23, 2024
Merged

(feat) Enable readonly radio buttons #109

merged 2 commits into from
Feb 23, 2024

Conversation

donaldkibet
Copy link
Member

@donaldkibet donaldkibet commented Dec 20, 2023 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR adds readOnly property on radio button to make it disabled to meet some specification.

Screenshots

Related Issue

Other

@donaldkibet donaldkibet changed the title Feat/make ready only radio buttons (feat) make ready only radio buttons Dec 20, 2023
@denniskigen denniskigen changed the title (feat) make ready only radio buttons (feat) Enable readonly radio buttons Jan 4, 2024
@donaldkibet donaldkibet requested review from icrc-psousa, ibacher and denniskigen and removed request for icrc-psousa February 22, 2024 13:44
makombe
makombe approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@makombe makombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @donaldkibet.

@donaldkibet donaldkibet merged commit d4c74ef into main Feb 23, 2024
3 checks passed
@donaldkibet donaldkibet deleted the feat/makeReadyOnlyRadioButtons branch February 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makombe makombe makombe approved these changes

@ibacher ibacher Awaiting requested review from ibacher

@icrc-psousa icrc-psousa Awaiting requested review from icrc-psousa

@denniskigen denniskigen Awaiting requested review from denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donaldkibet @makombe