Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Clear values of hidden fields #110

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

icrc-jofrancisco
Copy link
Contributor

@icrc-jofrancisco icrc-jofrancisco commented Dec 21, 2023

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This pull request addresses an issue with the hider functionality, specifically focusing on removing the values of hidden fields.

The current implementation retains the value for fields that are not visible, which can lead to the inadvertent saving of observations with both values and hidden status.

The proposed changes ensure that hidden fields have their values properly removed, preventing unintended data storage for concealed elements.

Screenshots

before:
chf_before

after:
chf_after

Related Issue

Other

Thanks,
CC: @ibacher

@icrc-jofrancisco icrc-jofrancisco changed the title (fix) clearing hidden field values (fix) Clear values of hidden fields Dec 21, 2023
@icrc-jofrancisco icrc-jofrancisco marked this pull request as draft December 21, 2023 19:08
@icrc-jofrancisco icrc-jofrancisco marked this pull request as ready for review December 22, 2023 14:26
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @icrc-jofrancisco!

@denniskigen denniskigen merged commit 1f2271c into openmrs:main Jan 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants