Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Make datepicker placeholder aware of datePickerFormat input #121

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Jan 22, 2024

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The DatePicker component accepts a datePickerType prop whose value gets funnelled down to the NgDatePicker component under the hood. This prop accepts one of three possible values:

  • both which renders both a calendar and a timer
  • calendar which renders a calendar
  • timer which renders a timer

Presently, the input placeholder is set to just show mm/dd/yyyy for all three cases. This PR amends the placeholder so an appropriate value is shown in each case.

Screenshots

Both

CleanShot 2024-01-22 at 4  19 12@2x

Timer

CleanShot 2024-01-22 at 4  19 24@2x

Calendar

CleanShot 2024-01-22 at 4  20 00@2x

Related Issue

Other

@denniskigen denniskigen merged commit 261eb1b into main Jan 22, 2024
3 checks passed
@denniskigen denniskigen deleted the feat/datepicker-placeholders branch January 22, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants