Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-2870: Form navigation fixes for RTL languages #124

Merged
merged 2 commits into from
Feb 19, 2024
Merged

(fix) O3-2870: Form navigation fixes for RTL languages #124

merged 2 commits into from
Feb 19, 2024

Conversation

elimm
Copy link
Contributor

@elimm elimm commented Feb 15, 2024 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR contains fixes to newly added navigation section:

  • translation for prev / next page
  • added title/popup with page name on button hover
  • correct alignment for RTL
  • horizontal scrolling / oveflow

Screenshots

Before:

Video

2024-02-15 14 03 52

After:

2024-02-15 13 52 53

Related Issue

O3-2870

Andrey Y added 2 commits February 15, 2024 13:35
(fix) O3-2870: Form navigation fixes
33382ad 
- translation for prev/next page
- fixed alignment for RTL
- fixed oveflow
(fix) O3-2870: Quickfix for nav button vertical alignmet
ff1d5dd
denniskigen
denniskigen approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @elimm. Thanks for the great work!

@denniskigen denniskigen merged commit 8594a4d into openmrs:main Feb 19, 2024
3 checks passed
@denniskigen denniskigen changed the title (fix) O3-2870: Form navigation fixes (fix) O3-2870: Form navigation fixes for RTL languages Feb 19, 2024
@elimm elimm deleted the bugfix/O3-2870 branch February 20, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elimm @denniskigen