Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Remove hidden fields from patient identifier question types #129

Merged
merged 1 commit into from
Mar 20, 2024
Merged

(fix) Remove hidden fields from patient identifier question types #129

merged 1 commit into from
Mar 20, 2024

Conversation

donaldkibet
Copy link
Member

@donaldkibet donaldkibet commented Mar 20, 2024 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR filters out hidden questions when generating patient identifiers.

Screenshots

Related Issue

Other

makombe
makombe approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@makombe makombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ojwanganto
Copy link

cc @denniskigen

@denniskigen denniskigen changed the title (fix) remove hidden fields from patient identifier (fix) Remove hidden fields from patient identifier question types Mar 20, 2024
@denniskigen
Copy link
Member

LGTM! Thanks, @donaldkibet.

@denniskigen denniskigen merged commit 8cee5e1 into main Mar 20, 2024
3 checks passed
@denniskigen denniskigen deleted the fix/patientidentifier branch March 20, 2024 20:26
@ojwanganto
Copy link

Thanks @denniskigen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@makombe makombe makombe approved these changes

@ibacher ibacher Awaiting requested review from ibacher

@icrc-jofrancisco icrc-jofrancisco Awaiting requested review from icrc-jofrancisco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donaldkibet @ojwanganto @denniskigen @makombe