Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(enhc) Update form-entry styling post carbon-styles upgrade #83

Merged
merged 3 commits into from
Oct 2, 2023
Merged

(enhc) Update form-entry styling post carbon-styles upgrade #83

merged 3 commits into from
Oct 2, 2023

Conversation

donaldkibet
Copy link
Member

@donaldkibet donaldkibet commented Oct 2, 2023 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Updated styles since update to core carbon styles.

Screenshots

Kapture 2023-10-02 at 14 22 30

Related Issue

Other

Designs https://app.zeplin.io/project/60d59321e8100b0324762e05/screen/61f03e914d1575a2cec45453

@donaldkibet donaldkibet requested a review from makombe October 2, 2023 11:55
@CynthiaKamau
Copy link
Contributor

Kindly add a screenshot of the new layout and squash the commits

@denniskigen
Copy link
Member

Thanks a whole bunch, @donaldkibet!

@denniskigen denniskigen merged commit f32decb into main Oct 2, 2023
3 checks passed
@denniskigen denniskigen deleted the enhacement/styles branch October 2, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@icrc-jofrancisco icrc-jofrancisco Awaiting requested review from icrc-jofrancisco

@makombe makombe Awaiting requested review from makombe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donaldkibet @CynthiaKamau @denniskigen