-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX np.NaN is not available anymore in numpy2.0 #111
Conversation
Not sure how to cope with the missing |
This seems relevant: scipy/scipy#17572 (comment) |
Looks like this works:
|
Looks good! Unless anyone objects, I can go ahead and merge it in a couple of days. |
Great :) Note that we saw this failure in the test of our benchmark on logreg l2, where we benchmark It has been a while since we updated the |
thanks all! |
Hey @fabianp : any chance to put out a pypi release (0.9.2?) that includes this fix? Thanks! |
should be done now, sorry for the delay
…On Wed, Sep 11, 2024 at 11:20 PM Ariel Rokem ***@***.***> wrote:
Hey @fabianp <https://github.com/fabianp> : any chance to put out a pypi
release (0.9.2?) that includes this fix? Thanks!
—
Reply to this email directly, view it on GitHub
<#111 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACDZBZ73RYJBI55U3QFWATZWCX2NAVCNFSM6AAAAABKD7BU3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUG4ZDEMRWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Just notived a failure with numpy 2.0.
This is a quick fix for the failure I observed.