Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcovebods: Add handling of BODS 0.4 data #144

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

radix0000
Copy link
Collaborator

Include BODS 0.4 schema, update to handle new jsonschema version, include BODS 0.4 specific checks, statistics and tests etc.

Include BODS 0.4 schema, update to handle new jsonschema version,
include BODS 0.4 specific checks, statistics and tests etc.
libcovebods/data_reader.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ghost
Copy link

ghost commented Dec 18, 2024

If you wanted to split up libcovebods/tasks/checks.py and libcovebods/tasks/statistics.py that would be cool. The files are now so big that GitHub says "Large diffs are not rendered by default." :-) Maybe to keep code changes in this PR readable, changes to existing classes stay in the same file but any new classes could be in new files? Just a suggestion tho, as I realise this may be more work for what is just code neatness.
Tho maybe that would end up with checks for the same thing in different versions in different files, which might not be great?

libcovebods/tasks/checks.py Outdated Show resolved Hide resolved
libcovebods/tasks/checks.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Dec 18, 2024

Is libcovebods/tasks/peps.py ok without a change? (but maybe that can be another PR!)

libcovebods/schema.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Dec 18, 2024

So libcovebods/data/schema-0-4-0.json is a dereferenced version of the schema, but it wasn't generated by the method described in https://github.com/openownership/lib-cove-bods?tab=readme-ov-file#updating-schema-files-in-data ? Could we just have a note saying this in readme?

I don't think we need to explain fully how it's generated at this time, as maybe we are about to fix compiletojsonschema so it can do so? Or if not we can update the readme later.

@radix0000
Copy link
Collaborator Author

Have broken up checks and statistics, also added some more statistics, a few more tests etc. The schema-0-4-0.json file was added as a test at some point but isn't used, and has been removed.

@radix0000 radix0000 requested a review from jarofgreen January 7, 2025 13:10
@radix0000 radix0000 merged commit 70b1156 into master Jan 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants