-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Excel button #122
Conversation
It would be nice if we could reposition it is not the primary visual that people should look at when being presented by the table. Users will look for it if needed. Should we also disable it by default and only enable in the tables in which it is needed? Or add a toggle in the app's settings |
… dom, exts, and opts
@jthompson-arcus, got the coveted ✅ |
eh, converting to draft since I lost the ✅ when merging |
@jthompson-arcus, this is ready for review. Regarding one of your earlier questions, I chose the path of creating a helper function to configure DT ext / options instead of altering But, it's all up for debate, so I'm all ears if you have comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments below.
Closes #96. This PR is currently an initial placeholder that generates the most basic of excel buttons using the "Buttons" extension for
{DT}
.Some possible enhancements include: