Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75 two columns of the same name in parametric test values #78

Merged

Conversation

xidongdxi
Copy link
Collaborator

Thank you for your Pull Request!

We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the graphicalMCP codebase remains robust and consistent.

Changes Description

Closes #75

When running a graphical MCP, the detailed test values data frame has two columns named *. This PR de-duplicates those names by removing them. Commits from #76 have been incorporated.

Task List

This is a list of tasks that can be done by contributors to make reviewing faster and more straightforward. If you're unsure how to do any or all of these, please make your contributions anyway. We are happy to work with you on any of them! However, know that your contributions may be more likely to be accepted, or be accepted more quickly, the more of these you can accomplish. They are roughly sorted in descending order of helpfulness.

  • Fill out Changes Description above
  • Update relevant unit tests or write new unit tests
  • Create/update relevant roxygen headers and examples
  • Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page
  • Update NEWS.md with a brief summary of changes made - Note the related issue number(s) at the end like (#000)
  • Make sure that the package versions in the NEWS.md and DESCRIPTION file are the same
  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Format code according to the tidyverse style guide (Run styler::style_pkg())
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Link the issue Development Panel so that the related issue closes after successful merging
  • Fix merge conflicts
  • Pat yourself on the back for a job well done! Here's a random cat gif for your hard work :)

@xidongdxi xidongdxi requested a review from EeethB March 1, 2024 16:41
Copy link
Contributor

@EeethB EeethB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this! Having non-standard column names is a little clunky. I think if we're pulling the * columns, maybe we should pull the <= column too? I added a commit that does a couple things:

  1. Removes the <= column
  2. Adds the operator columns back in during printing. It was not too complicated to do, and I think it adds clarity.

@xidongdxi let me know what you think of both changes, and we can go from their. Either one would be easy enough to revert if you don't prefer it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @EeethB! This change looks great. Let's proceed to merge the PR. Please approve the PR when you are ready. Many thanks.

@xidongdxi xidongdxi merged commit 5394157 into main Mar 4, 2024
11 checks passed
@xidongdxi xidongdxi deleted the 75-two-columns-of-the-same-name-in-parametric-test-values branch March 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two columns of the same name in parametric test values
2 participants