-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
75 two columns of the same name in parametric test values #78
75 two columns of the same name in parametric test values #78
Conversation
Merge the column * with its previous column, e.g., Weight*, to avoid duplicated columns of *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this! Having non-standard column names is a little clunky. I think if we're pulling the *
columns, maybe we should pull the <=
column too? I added a commit that does a couple things:
- Removes the
<=
column - Adds the operator columns back in during printing. It was not too complicated to do, and I think it adds clarity.
@xidongdxi let me know what you think of both changes, and we can go from their. Either one would be easy enough to revert if you don't prefer it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @EeethB! This change looks great. Let's proceed to merge the PR. Please approve the PR when you are ready. Many thanks.
Thank you for your Pull Request!
We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the graphicalMCP codebase remains robust and consistent.
Changes Description
Closes #75
When running a graphical MCP, the detailed test values data frame has two columns named *. This PR de-duplicates those names by removing them. Commits from #76 have been incorporated.
Task List
This is a list of tasks that can be done by contributors to make reviewing faster and more straightforward. If you're unsure how to do any or all of these, please make your contributions anyway. We are happy to work with you on any of them! However, know that your contributions may be more likely to be accepted, or be accepted more quickly, the more of these you can accomplish. They are roughly sorted in descending order of helpfulness.
pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" pagestyler::style_pkg()
)devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriately