Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP for GH action -> Fixes riskmetric badge #338

Merged
merged 5 commits into from
Feb 28, 2022
Merged

WIP for GH action -> Fixes riskmetric badge #338

merged 5 commits into from
Feb 28, 2022

Conversation

timtreis
Copy link
Collaborator

@timtreis timtreis commented Feb 28, 2022 •
edited
Loading

See #337

@timtreis timtreis added the bug Something isn't working label Feb 28, 2022
@timtreis timtreis self-assigned this Feb 28, 2022
@timtreis timtreis linked an issue Feb 28, 2022 that may be closed by this pull request
Riskmetric badge is not rendered correctly #337
Open
@timtreis timtreis closed this Feb 28, 2022
@timtreis timtreis deleted the 20220228_fix_riskmetric_badge branch February 28, 2022 11:16
@timtreis timtreis restored the 20220228_fix_riskmetric_badge branch February 28, 2022 11:32
@timtreis timtreis reopened this Feb 28, 2022
@timtreis
Copy link
Collaborator Author

Using riskmetric v0.1.1 restored our README to the expected output:

image

@ddsjoberg
Copy link
Collaborator

@timtreis the riskmetrics package has a CRAN release of v0.1.2, and the workflow is installing v0.1.1 from GitHub.

Does the riskmetrics pkg no longer support the functionality being used? If they no longer support the functionality, should it not just be removed from the README? If it's a bug in the recent release, would it not be better to file an issue and patch the bug and install the most recent GH version?

@timtreis
Copy link
Collaborator Author

timtreis commented Feb 28, 2022 •
edited
Loading

Yes, I intentionally set it to install v0.1.1 instead of the most recent release. While 0.1.1 correctly yields a value in [0,1], the 0.1.2 version gives something in the area of -1.5 which breaks the shields.io template and according to the riskmetric doc should be an invalid value anyway.

I have already filed an issue with them, but I'd suggest to just use 0.1.1 until it is fixed. More details in #337

ddsjoberg
ddsjoberg approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I would leave the issue open as a reminder to update the workflow after the bug is addressed in riskmetrics

@timtreis timtreis merged commit 7458f60 into develop Feb 28, 2022
@timtreis timtreis deleted the 20220228_fix_riskmetric_badge branch March 10, 2022 13:06
@timtreis timtreis restored the 20220228_fix_riskmetric_badge branch March 10, 2022 13:06
@timtreis timtreis deleted the 20220228_fix_riskmetric_badge branch May 9, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddsjoberg ddsjoberg ddsjoberg approved these changes

@SHAESEN2 SHAESEN2 Awaiting requested review from SHAESEN2

Assignees

@timtreis timtreis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Riskmetric badge is not rendered correctly
3 participants
@timtreis @ddsjoberg @actions-user