Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with incoming version of ggplot2 #461

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Compatibility with incoming version of ggplot2 #461

merged 4 commits into from
Jan 24, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break bayesplot.

What changes are proposed in this pull request?

This PR updates functionality in visR that suffers under the new version of ggplot2. To briefly summarise, visR makes several assumptions about the internal structure of the gtable structures that ggplot2 produces. Some of these structures have changes, most noteably guide boxes.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help visR get out a fix if necessary.

Which files are involved in this pull request and what changes were made?

You can see this in the 'Files changed' tab, but for compleness:

  • R/add_highlight.R
  • tests/testthat/helper.R
  • tests/testthat/test-utils-visR.R

Did you include unit tests for the proposed change/bug fix (https://testthat.r-lib.org/)?

No. The changes I made are necessarily covered by unit tests otherwise they wouldn't have been on my radar to fix them.

If there is an GitHub issue associated with this pull request, please provide link.

No.


Checklist for PR reviewer

  • PR branch has pulled the most recent updates from main branch. Ensure the pull request branch and your local version match and both have the latest updates from the main branch.
  • If a new function was added, function should be included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report()). Before you run, begin a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • Has NEWS.md been updated with the changes from this pull request under the heading indicating the latest version. If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Has the version number been incremented using usethis::use_version(which = "dev")
  • Run devtools::build_readme() to build the README.md file.
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@bailliem bailliem self-requested a review January 24, 2024 19:17
@bailliem
Copy link
Collaborator

thanks @teunbrand all looks good for me.

@bailliem bailliem merged commit 3983600 into openpharma:main Jan 24, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants