Compatibility with incoming version of ggplot2 #461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break bayesplot.
What changes are proposed in this pull request?
This PR updates functionality in visR that suffers under the new version of ggplot2. To briefly summarise, visR makes several assumptions about the internal structure of the gtable structures that ggplot2 produces. Some of these structures have changes, most noteably guide boxes.
To test the code changes with the release candidate, you can install it with the code below:
The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help visR get out a fix if necessary.
Which files are involved in this pull request and what changes were made?
You can see this in the 'Files changed' tab, but for compleness:
Did you include unit tests for the proposed change/bug fix (https://testthat.r-lib.org/)?
No. The changes I made are necessarily covered by unit tests otherwise they wouldn't have been on my radar to fix them.
If there is an GitHub issue associated with this pull request, please provide link.
No.
Checklist for PR reviewer
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Before you run, begin a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationNEWS.md
been updated with the changes from this pull request under the heading indicating the latest version. If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
devtools::build_readme()
to build theREADME.md
file.