Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi,I pull a request for add_server to upstream,and include testing code #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chunshengster
Copy link

Hi,agentzh , I have add a function for add_server() ,and made some test under Test::Nginx . Pls review the code ,and thx.

@chunshengster
Copy link
Author

sorry for this pr, I have not test weather the added server can take effect in proxy_pass http://bar

@chunshengster
Copy link
Author

I think i should write another function named add_peer ,which can add server from uscf->servers to uscf->peer.data,is that right ?

@agentzh
Copy link
Member

agentzh commented Mar 16, 2015

@chunshengster I'll have a look as soon as I have a chance :) Thanks for working on this.

@subnetmarco
Copy link

+1

@agentzh
Copy link
Member

agentzh commented May 8, 2015

@chunshengster Please ensure that your change can work with all the existing balancer modules like least_conn, ip_hash, and etc.

@chunshengster
Copy link
Author

Hi,now My team have done this work for all existing banlancer modules , after some time ,I will repull this request ,with some tests.

@esatterwhite
Copy link

Has there been any progress here? Would love to see this land.

@agentzh
Copy link
Member

agentzh commented Nov 17, 2015

@esatterwhite Have you looked at the new balancer_by_lua* directives in the balancer-by-lua github branch?

@esatterwhite
Copy link

Is that planned for an up coming release?

@agentzh
Copy link
Member

agentzh commented Nov 17, 2015

@esatterwhite It's in the public balancer-by-lua github branch of this repos. It'll get included in a future release, but not necessarily in the next release.

You're encouraged to try out that branch to ensure it fits your needs before it is set in the stone.

@hdavid
Copy link

hdavid commented Dec 1, 2016

hi,
this pull request would be super nice to have. any chances to get it merged ?

@lippertmarkus
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants