Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .dependsOn method for KotlinParser #617

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

tschut
Copy link
Contributor

@tschut tschut commented Nov 15, 2024

What's changed?

Add .dependsOn method for KotlinParser

What's your motivation?

Anything in particular you'd like reviewers to focus on?

  • The way I have to remove the sources from the returned list is not so nice. Perhaps there is a better way without refactoring the whole thing?
  • Need to add tests

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@tschut tschut marked this pull request as draft November 15, 2024 11:30
@timtebeek timtebeek added the enhancement New feature or request label Nov 15, 2024
github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

@tschut tschut marked this pull request as ready for review November 18, 2024 08:08
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here @tschut ! Hope this helps you write those self contained tests without dependencies. :)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/kotlin/KotlinTypeGoat.kt
    • lines 25-25
  • src/test/resources/KotlinTypeGoat.kt
    • lines 25-25

@timtebeek timtebeek merged commit a467f7c into openrewrite:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants