Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MigrateSpringdocCommon recipe #20

Closed
wants to merge 3 commits into from

Conversation

SiBorea
Copy link
Contributor

@SiBorea SiBorea commented Nov 20, 2024

What's changed?

There're a little changes between springdoc-openapi-common-1.+ and springdoc-openapi-starter-common-2.+

  1. org.springdoc.core.customizers.OpenApiCustomiser => org.springdoc.core.customizers.OpenApiCustomizer
  2. org.springdoc.core.GroupedOpenApi => org.springdoc.core.models.GroupedOpenApi
  3. addOpenApiCustomiser() => addOpenApiCustomizer()

Checklist

  • [✅] I've added unit tests to cover both positive and negative cases
  • [✅] I've read and applied the recipe conventions and best practices
  • [✅] I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor

Thanks for the effort here! Up to now we had kept the springdoc related recipes in rewrite-spring:
https://github.com/openrewrite/rewrite-spring/blob/main/src/main/resources/META-INF/rewrite/springdoc.yml

Would it make sense to move this there as well? And have it be included with the other recipes there? Those are then tied in with Spring Boot migrations from there.

@SiBorea
Copy link
Contributor Author

SiBorea commented Nov 21, 2024

I filed a PR for it: openrewrite/rewrite-spring#633
Should I close this one?

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@timtebeek
Copy link
Contributor

Thanks! Yes let's close this one and continue in

@timtebeek timtebeek closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants